Skip to content

Improved cmake build to build without to checkout "external/json" manually#5

Open
Bjoe wants to merge 3 commits into
taocpp:mainfrom
Bjoe:improve-cmake-build
Open

Improved cmake build to build without to checkout "external/json" manually#5
Bjoe wants to merge 3 commits into
taocpp:mainfrom
Bjoe:improve-cmake-build

Conversation

@Bjoe

@Bjoe Bjoe commented Apr 20, 2021

Copy link
Copy Markdown
Contributor

This PR will fix the problem, if you would like to build these project against an already installed JSON "lib"/header.
Also I implemented a solution to "fetch" the sources without to fetch the sources "manually" into external/json

@codecov-commenter

codecov-commenter commented Apr 20, 2021

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@ColinH ColinH requested a review from d-frey April 20, 2021 16:27
@Bjoe

Bjoe commented Apr 20, 2021

Copy link
Copy Markdown
Contributor Author

Unfortunately there is following in your JSON (also PEGTL) project:

In the JSON project you "alias" the JSON target from taocpp-json to ``taocpp::json. But when you "install" the lib/header and provide the cmake config-modul, the target is exported as taocpp::taocpp-json` because when you "export" the project it will be exported with the given namespace from `install(EXPORT ..... NAMESPACE ....)` in your solution it is `taocpp::` plus the target name, in your solution `taocpp-json`. The result is `taocpp::taocpp-json`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants