Skip to content

fix: attachFormValue did not consider value as JSON object such as reply_parameters#1992

Open
clansty wants to merge 1 commit into
telegraf:v4from
clansty:patch-1
Open

fix: attachFormValue did not consider value as JSON object such as reply_parameters#1992
clansty wants to merge 1 commit into
telegraf:v4from
clansty:patch-1

Conversation

@clansty

@clansty clansty commented May 19, 2024

Copy link
Copy Markdown

fix #1970

@phattranky phattranky left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I tested on my local and it actually can fix the issue #1970 very well

TestCapture
tested 2Capture

@migue802 migue802 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, tested using @phattranky temporary fix

@callmewhy

Copy link
Copy Markdown

any update?

@clansty

clansty commented Dec 23, 2024

Copy link
Copy Markdown
Author

no, migrated to grammy

@siakinnik

Copy link
Copy Markdown

Hi! Upstream is dead since last year, so I've started a community fork telegraf-hardened. I'd love to have your PR there: https://github.com/siakinnik/telegraf-hardened/issues/1

@Leask

Leask commented May 5, 2026

Copy link
Copy Markdown

Included in #2092 via commit 877d951, with multipart object-field regression coverage.

Tracking PR: #2092

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

reply_parameters doesn't work in Context.replyWithPhoto

6 participants