ENG-1756: (WIP!) Malloc Benchmark Testing#476
Draft
besler613 wants to merge 9 commits into
Draft
Conversation
ENG-1756 QOS - Benchmark Testing for StageX Containers
ProblemOne takeaway of this conversation, which describes the Mysten team's discovery of suboptimal memory allocation in our StageX kernels as well as their plans to address this by modularizing the allocators so they can be swapped, was that Turnkey would benefit from the incremental development of low-level benchmark testing for our base StageX images. SolutionDevelop a Suite of Benchmark Tests in our QOS library with testing patterns loosely based on the characteristic operations of Turnkey applications. This suite could be built out on an as-needed basis, with the first components focusing on Memory Allocation Performance. Deliverables
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary & Motivation (Problem vs. Solution)
This PR introduces minimalistic memory allocation benchmark testing for our base QOS images. The basic design ideas are:
benchmarkingcontainer definition (src/images/benchmarking/Containerfile) requires aBASE_IMAGEargument to be provided, and uses that argument to essentially "inherit" from the base image. This guarantees that the benchmarking image is identical to the base image, with the only addition being the benchmarking binaries and the/benchmarkentrypoing.kustomize/components/qos_enclave_benchmarking) to a shared locationkustomize/components/base, which is consumed by both the base component and the benchmarking version. Again, this guarantees that the benchmarking component uses identical infra as the base component, with the only difference being that the container definition references the benchmarking image (see above).How I Tested These Changes
TBD
Pre merge check list