mesa: on %cork, remove any %peek for $boon#7364
Draft
yosoyubik wants to merge 8 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we left a subscription in the middle of peeking for a multi-fragmemnt $boon, and the %cork $ack came before the $boon page was delivered, we would create a space leak in the .pit by not removing the payload peek.
I reorder the code a bit here and also to move the logic for peeking for multifragment payloads into the flow layer.
Also, I (re)add the authentication for the %auth fragment in a %poke, that was somehow not pushed?(probably due to some merge conflicts)