fix(core): remove 1-9 digit key seek from slider keyboard handler#1690
Open
ronald-urbina wants to merge 1 commit into
Open
fix(core): remove 1-9 digit key seek from slider keyboard handler#1690ronald-urbina wants to merge 1 commit into
ronald-urbina wants to merge 1 commit into
Conversation
👷 Deploy request for vjs10-site pending review.Visit the deploys page to approve it
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The slider's keydown handler was directly handling digit keys 0–9 to seek to decile positions (10%, 20%, etc.). This meant removing from an ejected skin had no effect, the keys still fired through the slider.
Now this logic belongs exclusively in the layer where it can be opted out of.
Removes the digit key handling from createSlider and the corresponding tests.
Closes #1655
Note
Low Risk
Narrow keyboard behavior change in the slider DOM layer; digit seek remains available via hotkeys when configured.
Overview
Removes 0–9 digit keyboard seeking from
createSlider’s thumbonKeyDownhandler so decile jumps (0%, 10%, …, 90%) are no longer hard-coded in the slider UI layer.Arrow keys, Home/End, Page Up/Down, and related stepping behavior are unchanged. Digit-based seek is intended to live only in
<media-hotkey>(0-9→seekToPercent), so custom/ejected skins can drop those hotkeys without the progress slider still intercepting number keys when the thumb is focused.Corresponding unit tests for numeric keys and modifier suppression are removed.
Reviewed by Cursor Bugbot for commit 73bf118. Bugbot is set up for automated code reviews on this repo. Configure here.