runtime(beancount): add language files#20373
Conversation
|
This is taken from https://github.com/nathangrigg/vim-beancount, hence why I set @nathangrigg as the author. It does not include:
|
|
Please Update MAINTAINER file And I remember that every files needs a header. Take a look at files in the same directory. You can't set others as maintainer unless you have their permission. |
|
Thanks, but do we really need those autoloaded functions here in the Vim tree? I am not sure how popular beancount is, well it doesn't seem to be for me. So I'd suggest just importing the indent, syntax and ftplugin and leave the rest as a separate plugin |
|
Apart from bean count. There also has some similar project and need has similar stars. Like ledger cli and hledger. That is hard to say whether include things in autoload is a good idea. |
Sure, I don't really have a strong opinion either way, as noted in my first comment I initially uploaded without them. |
Did you seek approval from the author for inclusion in the Vim runtime? Even if licensing allows it we generally like to have approval from the original author. There can be negative consequences for the main project from partial distribution with Vim. |
|
Yes, I reached out to him privately, he gave his approval. |
|
@nathangrigg can you please confirm and give public approval here? Thanks |
|
You have my approval, thanks |
|
alright thanks all |
chrisbra
left a comment
There was a problem hiding this comment.
I am afraid at the current state, this is not yet suitable for inclusion. Also, is there a reason, you did not include the documentation? That should go into runtime/doc/filetype.txt
Forgot about it 🙃. |
|
A condensed doc for the filetype has been added to |
| \ :call beancount#get_context() | ||
|
|
||
| " Omnifunc for account completion. | ||
| if exists('g:beancount_completion_enable') && (g:beancount_completion_enable == 1) |
There was a problem hiding this comment.
It doesn't look like any other files in ftplugin check for that value?
94abe3e to
ef37461
Compare
|
Did you test this out? |
|
Not with the changes from review. I was waiting for reviews to be done first. |
|
There was a small typo in the suggested code. I've tested the update runtime files, they seem to be functional. |
Problem: beancount is recognized, but otherwise inert
Solution: import the filetype, syntax, indent, and compiler files from
`vim-beancount`.
|
@nathangrigg please review the changes in the Vim commit 1fee3cd that have been done as part of including your maintained version of the beancount runtime files. There were quite a few changes added to make it a bit more robust and secure. If you notice anything you'd like to change, please create a follow-up PR. Thanks 🙏 |
Problem: beancount is recognized, but otherwise inert
Solution: import the filetype, syntax, indent, and compiler files from
vim-beancount.