Fix Library crash with CJK characters in book titles#132
Open
meiningnie wants to merge 1 commit into
Open
Conversation
CJK characters (Chinese, Japanese, Korean) occupy 2 terminal columns, but the code truncated strings by character count instead of display width. This caused pad.addstr() to overflow and crash when displaying Library items with CJK characters in titles. Added display_width() and truncate_by_width() functions to properly handle character width when truncating strings for display.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CJK characters (Chinese, Japanese, Korean) occupy 2 terminal columns, but the code truncated strings by character count instead of display width. This caused pad.addstr() to overflow and crash when displaying Library items with CJK characters in titles.
Added display_width() and truncate_by_width() functions to properly handle character width when truncating strings for display.