Skip to content

Enable docker-listener wodle#609

Open
kravietz wants to merge 1 commit into
wazuh:4.3from
kravietz:patch-2
Open

Enable docker-listener wodle#609
kravietz wants to merge 1 commit into
wazuh:4.3from
kravietz:patch-2

Conversation

@kravietz

Copy link
Copy Markdown
Contributor

alberpilot
alberpilot previously approved these changes Nov 24, 2021

@alberpilot alberpilot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@myu1d157h0u54nd

Copy link
Copy Markdown
Contributor

Hello @kravietz
Thank you for using Wazuh and contributing to improve it. I will be taking this PR for testing and review.
In our master branch it corresponds to the development version. It is possible that I will move the destination of the merge to branch 4.2 to take it to the stable branch within the flow that we carry.

@alberpilot alberpilot changed the base branch from master to 4.3 November 24, 2021 16:05
@alberpilot alberpilot dismissed their stale review November 24, 2021 16:05

The base branch was changed.

@myu1d157h0u54nd

Copy link
Copy Markdown
Contributor

Hi @kravietz
After doing some tests, I see that it is necessary to add additional changes. Can you please add them to your PR so that the contribution record is kept by you?

They would be in: roles/wazuh/ansible-wazuh-agent/defaults/main.yml
within:

# wazuh_agent_config
wazuh_agent_config_defaults:

add:

  docker_listener:
    disable: 'yes'

and in: roles/wazuh/ansible-wazuh-agent/tasks/Linux.yml

- name: Linux | Ensure group "wazuh" exists
  group:
    name: wazuh
    state: present

@duviful

duviful commented Apr 21, 2023

Copy link
Copy Markdown

I am looking forward to seeing this functionality merge. I will handle the code.

@itprogression @alberpilot, Should I start a new PR? I don't know if GitHub lets me contribute to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants