Local icons#790
Draft
Stoppedpuma wants to merge 6 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long overdue PR. This allows icons to be locally generated. The previous method was using iconamoon. This was annoying for updating icons and had woelper doing a little guess work from time to time for which icon was which. The icons now match the figma icons page names and are all on a 24x24 frame. There's been some sizing woes, but hopefully this is the PR to fix that with a bit of work.
For this to be merged, the sizing issues must be fixed since they are all over the place, and there's this odd issue spacing issue in file manager which I've tried to figure out but only got this far:
Completing this PR should close #747
@woelper Pinging you in hopes that you hopefully would be able to help out here. I'm a bit stuck on the issue of sizing being all over the place.