updating default Retribution APL#4184
Open
Surveillant0 wants to merge 1 commit into
Open
Conversation
DS > CS rotation (aka High-roll)
Contributor
Author
|
not sure if I need to fix a bug somewhere or if I need to update expected results, first time updating an APL |
Contributor
|
Hey @Surveillant0! Looks like the update is making the tests fail (which isn't surprising). Since the numbers went up I assume that's totally fine, so you can run |
Contributor
Author
thanks I will do this as soon as I am able to! appreciate the reply |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DS > CS rotation (aka High-roll) as the new default
includes a condition to prio CS higher if Libram duration is low
for people without the Libram, the rotation will end up doing CS > DS instead, unless that action is disabled
however CS > DS is still a perfectly fine and optimal rotation anyway
also includes cancelaura action for Shadowmourne but this is disabled by default, as it is currently bugged in-game