Fix: docker build#4264
Open
jacksonwilliams wants to merge 4 commits into
Open
Conversation
add the .nvmrc file to gitignore as it causes the docker build to fail if it exists.
remove .nvmrc file as it casues the docker build to fail if its present.
update run nvm.sh from 3 files into 1 to reduce the number of laters and remove duplication
move NODE_VERSION and NVM_DIR to the top for ease of editing. update apt get RUN commands to single line copy go.mod and go.sum in for minimal go setup. push COPY . . to the bottom as it takes the longest and should run last where possible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docker build was failing due to .nvmrc file
added .nvmrc to gitignore and removed from repository
combined some of the RUN lines to reduce the number of layers and try to optimize a little