Remove jQuery and tablesorter CDN dependencies#4285
Open
PGrayCS wants to merge 1 commit into
Open
Conversation
Replace the jQuery tablesorter plugin with a lightweight vanilla TypeScript TableSorter class. This removes two external CDN script tags (jQuery 3.5.1 and jquery.tablesorter 2.31.3) from the page template and replaces the jQuery-dependent calls in MetricsTable with a self-contained implementation. The new TableSorter handles column header click sorting and correctly maintains parent-child row relationships (child-metric rows stay attached to their parent during re-sorts). Numeric columns are sorted numerically using data-text dataset attributes; string columns fall back to locale- aware string comparison. Closes wowsims#4272
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4272.
Replaces the jQuery + jquery.tablesorter CDN dependencies with a lightweight, self-contained vanilla TypeScript
TableSorterclass, ported from the equivalent change already merged in wowsims/sod (PR #1435).Changes:
ui/core/components/detailed_results/table_sorter.ts— NewTableSorterclass. Reads sort values fromdata-textdataset attributes (falling back toinnerText), handles numeric and string columns, and keepschild-metricrows attached to their parent row during re-sorts.ui/core/components/detailed_results/metrics_table.tsx— Removedeclare var $: any;, importTableSorter, replace$(this.tableElem).tablesorter(...)with aTableSorterconstructor call, replace$(this.tableElem).trigger('update')withthis.sorter.update(), and setdata-texton cells that have agetValuefunction so numeric sorting works correctly.ui/index_template.html— Remove the jQuery 3.5.1 and jquery.tablesorter 2.31.3<script>tags.Test plan