Skip to content

[pull] master from blevesearch:master#87

Merged
pull[bot] merged 2 commits into
yataOrg:masterfrom
blevesearch:master
Jun 1, 2026
Merged

[pull] master from blevesearch:master#87
pull[bot] merged 2 commits into
yataOrg:masterfrom
blevesearch:master

Conversation

@pull

@pull pull Bot commented Jun 1, 2026

Copy link
Copy Markdown

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

- Currently we always compute the vector index size, irrespective of
whether this size was cached in the snapshot's `cachedMeta` or not. We
use the cached value when triggering the searcher start callback, but do
not check if it exists in the `cachedMeta` before calling the `Size()`
API.
- Due to recent changes, the output of the `Size()` API was fixed but at
the cost of additional computation to get a precise estimate. This
results in a perf regression due to the aforementioned point.
- Fix this issue by performing a `LoadOrStore` operation for the size
instead, where we perform a read to check if the size was cached, and
only compute it if not cached.
- Refactor `cachedMeta` to use a `sync.Map` instead of a map with a RW
mutex as its more suited for the `write-once-read-many` style of usage
which we use it for in this perspective.
- Fix the `TotKNNSearches` to be equal to the number of KNN searchers
created, which mirrors the FTS equivalent `TotTermSearchersFinished`,
currently this stat is equal to `N` * `X` where `N` is the number of
segments, refactor it to report just `X`.
- Upgrade `github.com/blevesearch/zapx/v17` to `v17.1.6`
@pull pull Bot locked and limited conversation to collaborators Jun 1, 2026
@pull pull Bot added the ⤵️ pull label Jun 1, 2026
@pull pull Bot merged commit 859d1a6 into yataOrg:master Jun 1, 2026
9 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant