[pull] master from blevesearch:master#87
Merged
Conversation
- Currently we always compute the vector index size, irrespective of whether this size was cached in the snapshot's `cachedMeta` or not. We use the cached value when triggering the searcher start callback, but do not check if it exists in the `cachedMeta` before calling the `Size()` API. - Due to recent changes, the output of the `Size()` API was fixed but at the cost of additional computation to get a precise estimate. This results in a perf regression due to the aforementioned point. - Fix this issue by performing a `LoadOrStore` operation for the size instead, where we perform a read to check if the size was cached, and only compute it if not cached. - Refactor `cachedMeta` to use a `sync.Map` instead of a map with a RW mutex as its more suited for the `write-once-read-many` style of usage which we use it for in this perspective. - Fix the `TotKNNSearches` to be equal to the number of KNN searchers created, which mirrors the FTS equivalent `TotTermSearchersFinished`, currently this stat is equal to `N` * `X` where `N` is the number of segments, refactor it to report just `X`.
- Upgrade `github.com/blevesearch/zapx/v17` to `v17.1.6`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )