[18.0][FIX] web_company_color: integer division in image color extraction#3551
Open
fsmw wants to merge 1 commit into
Open
[18.0][FIX] web_company_color: integer division in image color extraction#3551fsmw wants to merge 1 commit into
fsmw wants to merge 1 commit into
Conversation
MarwanBHL
suggested changes
May 20, 2026
MarwanBHL
left a comment
Contributor
There was a problem hiding this comment.
I tested it in Runboat and it's not working. And don't change the version, the bot does it automatically.
…eger division Use i // width instead of i / width so getpixel() receives integer coordinates (Pillow >= 10.2 compatible). Catch PIL.UnidentifiedImageError in convert_to_image() and raise a user-friendly UserError instead of a traceback. Add test for invalid image data in convert_to_image().
10e5775 to
e4a0cff
Compare
Author
|
Thanks for the review. I've addressed both points:
Ready for re-review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #3532
In image_to_rgb() pixel loop uses i / width returning float in Python 3, causing getpixel() to raise TypeError in Pillow >= 10.2.0 because coordinates must be integers. This completely blocks color extraction when a logo is set.
Steps to reproduce
Fix
Replace i / width with i // width so getpixel() receives integer coordinates.
Backward Compatibility
Fully backward compatible; the behavior is identical for valid integer widths and fixes the crash with newer Pillow.