OC-17767:Check XSS finding in report#3552
Open
Taoli2018 wants to merge 1 commit into
Open
Conversation
svadla-oc
requested changes
Jan 26, 2023
| /** | ||
| * check unsafe input | ||
| */ | ||
| int index = findSubjectsHtml.indexOf("jQuery.jmesa.addFilterToLimit('findSubjects','studySubject.label',"); |
Contributor
There was a problem hiding this comment.
Instead of fixing it specifically for the matrix, let's try to fix it globally like we did for OC4.
Contributor
Author
There was a problem hiding this comment.
I merged OC4 fix, and tested at my local, looks like the fix of OC4 can't fix the issue reported in OC3, OC4 fix is to handle XSS when user/attacker enter value at input fields from matrix table, but OC3 reported the XSS issue is user/attacker start XSS attack from URL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.