perf(CAPTCHA): verify CAPTCHA responses using subrequests instead of libcurl#140
Draft
ADD-SP wants to merge 2 commits into
Draft
perf(CAPTCHA): verify CAPTCHA responses using subrequests instead of libcurl#140ADD-SP wants to merge 2 commits into
libcurl#140ADD-SP wants to merge 2 commits into
Conversation
Introducing multi-threading for CPU intensity work in the Nginx makes no sense.
libcurllibcurl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This module needs to send HTTP requests to the CAPTCHA server to verify if the CAPTCHA passes. Currently, this was done by the
libcurl, but this blocks the event loop of the Nginx, so replacing it with subrequests is more efficient.