fix: recover library covers when source URL goes stale#988
Open
neldra wants to merge 3 commits into
Open
Conversation
On HTTP 403/404/410 from a library cover load, refetch manga details via MangaManager.resetCover and retry with the fresh URL. Throttled to one attempt per manga per session.
|
|
Skittyblock
requested changes
May 31, 2026
Skittyblock
left a comment
Member
There was a problem hiding this comment.
thanks, i haven't tested but i think this is probably a good idea to have
- replace the GCD lock with a private actor for the dedup set - store MangaIdentifier in cells instead of separate source/manga ids
Author
|
Addressed both: swapped the GCD lock for a private actor managing the attempt set, and switched the cells + recover over to MangaIdentifier. Thanks for the review! |
Skittyblock
approved these changes
Jun 7, 2026
Skittyblock
left a comment
Member
There was a problem hiding this comment.
lgtm, will merge before the next app update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #326.
On HTTP 403/404/410 from a library cover load, refetch manga details via
MangaManager.resetCoverand retry with the fresh URL. Throttled to one attempt per manga per session. Applied to bothMangaGridCellandMangaListCell.Also includes a small unrelated fix updating
TrackerSyncTestsfor thetrackItemrename in #976, so the test target compiles locally.