[ACS-11719] init-aps and init-acs deleted from repo#11878
Draft
adamswiderskipw wants to merge 1 commit into
Draft
[ACS-11719] init-aps and init-acs deleted from repo#11878adamswiderskipw wants to merge 1 commit into
adamswiderskipw wants to merge 1 commit into
Conversation
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the legacy init-aps-env and init-acs-env CLI environment-initialization scripts from @alfresco/adf-cli, aligning the repo with the fact that these environment initialization steps are already handled by Terraform jobs.
Changes:
- Deleted
init-aps-envandinit-acs-envscripts fromlib/cli/scripts/. - Removed their exports from the CLI scripts barrel (
lib/cli/scripts/index.ts). - Updated CLI documentation to no longer list
init-aps-envas an available command.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/cli/scripts/init-aps-env.ts | Deletes the APS environment initialization script. |
| lib/cli/scripts/init-acs-env.ts | Deletes the ACS environment initialization script. |
| lib/cli/scripts/index.ts | Stops exporting removed CLI scripts. |
| lib/cli/README.md | Removes init-aps-env from the documented command list. |
Contributor
AleksanderSklorz
left a comment
There was a problem hiding this comment.
@adamswiderskipw please address (fix or answer as invalid) copilot's comment
Contributor
|
@adamswiderskipw is there anything else to make if review ready? |
AleksanderSklorz
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
init-aps and init-acs are not needed in this repo, as they are already running in the terraform jobs.
What is the new behaviour?
https://hyland.atlassian.net/browse/ACS-11719
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: