Skip to content

Bundle adjustment issue #47

Description

@Tenivar

Hi,

I've encountered some issues with bundleadjustment, both related to configuration validation.

When the sparse matching configuration is created in bundleadjustment.py, the configuration check fails if the output section contains keys other than directory.
This can be fixed by a one liner replacement line 593 with:

sparse_matching_config["output"] = {"directory": sparse_matching}

Also, the current CARS pipeline does not recognize the rectification_grids argument present in the bundle-adjusted configuration files. As a result, running CARS with the generated adjusted configurations fails during configuration validation.
Removing this key before generating the configurations fixes the issue:

conf_as_dict["input"].pop("rectification_grids", None)

This can be added around line 614.

Both changes fixed the bundle-adjustment workflow on my side.

Happy to make a PR if needed !
Thomas

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions