fix: preserve element text content during MEI3→MEI5 conversion#25
Open
kyrieb-ekat wants to merge 1 commit into
Open
fix: preserve element text content during MEI3→MEI5 conversion#25kyrieb-ekat wants to merge 1 commit into
kyrieb-ekat wants to merge 1 commit into
Conversation
ET.Element() copies tag and attributes but not .text or .tail, so all text content (including mei:l OCR lines) was silently dropped. Also fix root element losing its attributes (meiversion etc.), update output filename to match the existing mei5 naming convention, and rewrite liberbatch.py to process all three subdirectories and write output to the correct Liber Usualis - mei5/ directories. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ET.Element(tag, attribs)copies tag and attributes but silently drops.textand.tail, so all element text content (includingmei:lOCR text lines) was lost during conversion — elements were written as self-closing with no contentmeiversionand others*NEW2.meito* - mei5.meito match the existing MEI5 naming conventionliberbatch.pyrewritten to process all three subdirectories and write output to the correctLiber Usualis - mei5/directories (previously it only ran on the current directory and had a filename mismatch with the checker)Test plan
0001_corr.meiand verifiedmei:lelements contain text (e.g.<mei:l ...>we lux odds</mei:l>)python3 liberbatch.pyfrom repo root to convert all ~2300 filesMEIText2Solr.pyand confirm search returns results🤖 Generated with Claude Code