Skip to content

Hwallace/feature/unique dals#616

Merged
mroda88 merged 18 commits intodevelopfrom
hwallace/feature/unique_dals
Feb 11, 2026
Merged

Hwallace/feature/unique dals#616
mroda88 merged 18 commits intodevelopfrom
hwallace/feature/unique_dals

Conversation

@henry-wallace-phys
Copy link
Contributor

@henry-wallace-phys henry-wallace-phys commented Feb 4, 2026

Description

App to find non-unique entries in the configuration and allow the user to change them. There are 3 methods used for uniquenesss

  • Prompt: The user is prompted for each entry and has to manually enter a new name
  • Inheritance: All non-unique objects will be renamed based on some inheritance based pattern [<top_level>_]

The user will recieve a summary as a CSV.

Addresses issue #
Currently uniqueness is not enforced in configuration

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (daqsystemtest_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Comments here on the testing

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

@mroda88 mroda88 added the enhancement New feature or request label Feb 4, 2026
Copy link
Contributor

@mroda88 mroda88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in a quite usable state. So as this is not interfering with anything else, we are merging and we will collect feedback when this is deployed.

@mroda88 mroda88 merged commit 1a52082 into develop Feb 11, 2026
3 checks passed
@mroda88 mroda88 deleted the hwallace/feature/unique_dals branch February 11, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments