Skip to content

Don't consider it an error if CONNECTION_PORT Variable is not set#629

Draft
mroda88 wants to merge 2 commits into
developfrom
gcrone/optional_connection_port
Draft

Don't consider it an error if CONNECTION_PORT Variable is not set#629
mroda88 wants to merge 2 commits into
developfrom
gcrone/optional_connection_port

Conversation

@mroda88

@mroda88 mroda88 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Description

It seems that this variable is ignored everywhere and it requires a double definition. It should be removed

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (dunedaq_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Comments here on the testing

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

@mroda88 mroda88 added the good first issue Good for newcomers label Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants