Skip to content

Correcting the constructor for the ProtoBuf conf#50

Merged
PawelPlesniak merged 1 commit intodevelopfrom
PawelPlesniak/IntegTestFix
Feb 17, 2026
Merged

Correcting the constructor for the ProtoBuf conf#50
PawelPlesniak merged 1 commit intodevelopfrom
PawelPlesniak/IntegTestFix

Conversation

@PawelPlesniak
Copy link
Collaborator

Description

The default_factory should always have been None.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (dunedaq_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Comments here on the testing

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

@PawelPlesniak PawelPlesniak changed the title hotfix Correcting the constructor for the ProtoBuf conf Feb 17, 2026
@jcfreeman2
Copy link
Contributor

Confirmed that in a work area based on NFD_DEV_260217_A9, if I install daqpytools and drunc off their PawelPlesniak/IntegTestFix branches that minimal_system_quick_test.py works once again.

@PawelPlesniak PawelPlesniak merged commit 7b81745 into develop Feb 17, 2026
4 checks passed
@PawelPlesniak PawelPlesniak deleted the PawelPlesniak/IntegTestFix branch February 17, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants