Use googles rich error model for grpc errors in Process Manager client#666
Merged
PawelPlesniak merged 2 commits intodevelopfrom Nov 10, 2025
Conversation
…-model-for-grpc-errors-in-process-manager-client
PawelPlesniak
approved these changes
Nov 10, 2025
Collaborator
PawelPlesniak
left a comment
There was a problem hiding this comment.
Tested with MSQT, and manually by inserting a grpc error into the SSH PM. Errors much clearer.
Contributor
jamesturner246
left a comment
There was a problem hiding this comment.
Sorry I'm late. Thanks for this. Looks fine. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #662
The implementation is identical to that of the Session Manager Client, making use of the
extract_grpc_rich_errormethod.Type of change
Key checklist
python -m pytest)pre-commit run --all-files)Further checks
(Indicate issue here: # (issue))