[Snyk] Security upgrade wagmi from 2.12.12 to 3.0.0#15
[Snyk] Security upgrade wagmi from 2.12.12 to 3.0.0#15
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-ELLIPTIC-8187303 - https://snyk.io/vuln/SNYK-JS-SHAJS-12089400 - https://snyk.io/vuln/SNYK-JS-ELLIPTIC-8720086 - https://snyk.io/vuln/SNYK-JS-CROSSSPAWN-8303230 - https://snyk.io/vuln/SNYK-JS-WS-7266574 - https://snyk.io/vuln/SNYK-JS-MICROMATCH-6838728
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Summary of ChangesHello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, focuses on enhancing the project's security by upgrading the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request, automatically generated by Snyk, proposes upgrading the wagmi package from 2.12.12 to 3.0.0 to fix several security vulnerabilities. While addressing security issues is important, this upgrade is a major version bump and introduces significant risks. The target version 3.0.0 of wagmi does not appear to be publicly available, which will likely cause the build to fail. Furthermore, a major version upgrade of wagmi would introduce breaking changes that require updates to dependent packages like @rainbow-me/rainbowkit and modifications to the application code where wagmi is used. These related changes are not included in this PR. Therefore, merging this PR as-is is highly likely to break the application. I recommend rejecting this automated PR and performing a manual, careful upgrade of the web3 dependencies instead.
| "sharp": "^0.32.6", | ||
| "viem": "^2.13.1", | ||
| "wagmi": "^2.12.12", | ||
| "wagmi": "^3.0.0", |
There was a problem hiding this comment.
This upgrade to wagmi@3.0.0 is likely to break the application for two critical reasons:
-
Non-existent Package Version: Version
3.0.0ofwagmidoes not appear to exist on the public npm registry. This will cause dependency installation to fail. The previous version2.12.12also seems to be non-public, which might suggest a private registry is in use. Even so, the availability of version3.0.0must be confirmed. -
Breaking Changes & Incompatibility: This is a major version upgrade, which implies breaking changes. The project uses
@rainbow-me/rainbowkit@^2.1.5, which is designed forwagmi@2.x. Upgradingwagmito a new major version without also upgrading RainbowKit to a compatible version will almost certainly break the wallet functionality, as the configuration and APIs are likely to be incompatible.
Due to these critical issues, it is recommended to revert this change. A manual upgrade should be performed, carefully considering the breaking changes and updating all related dependencies like @rainbow-me/rainbowkit and application code accordingly.
| "wagmi": "^3.0.0", | |
| "wagmi": "^2.12.12", |
Snyk has created this PR to fix 6 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
package.jsonyarn.lockNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-ELLIPTIC-8187303
SNYK-JS-SHAJS-12089400
SNYK-JS-ELLIPTIC-8720086
SNYK-JS-CROSSSPAWN-8303230
SNYK-JS-WS-7266574
SNYK-JS-MICROMATCH-6838728
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)