fix(connector): stay in CapabilitiesExchange when activation handles DeactivateAll#1371
Open
Rocco De Angelis (rdeangel) wants to merge 1 commit into
Conversation
…DeactivateAll PR Devolutions#1254 taught the inner ConnectionActivationSequence to skip a Server Deactivate All PDU received before Server Demand Active (sent by e.g. Windows Server and gnome-remote-desktop during a Deactivation-Reactivation Sequence, MS-RDPBCGR 1.3.1.3): it returns Written::Nothing and stays in CapabilitiesExchange. However, the outer ClientConnector::step() only accepted ConnectionFinalization as the resulting inner state, so the same scenario still failed with "invalid state (this is a bug)" during the initial connection sequence. Mirror the inner behavior in the outer state machine and keep waiting for the Demand Active PDU. Fixes Devolutions#1362 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1362
Problem
#1254 taught the inner
ConnectionActivationSequenceto skip a Server Deactivate All PDU received before Server Demand Active (sent by e.g. Windows Server and gnome-remote-desktop as part of a Deactivation-Reactivation Sequence, MS-RDPBCGR 1.3.1.3): it returnsWritten::Nothingand remains inCapabilitiesExchange.However, the outer
ClientConnector::step()only acceptsConnectionFinalizationas the resulting inner state after callingconnection_activation.step(), so the same scenario still fails withinvalid state (this is a bug)when it happens during the initial connection sequence — exactly the symptom reported in #1362.Changes
ClientConnector::step(): when the inner sequence stays inCapabilitiesExchange, the outer connector stays inCapabilitiesExchangetoo and waits for the next input.ClientConnectorinstead of the inner sequence (fails withinvalid statebefore the fix).🤖 Generated with Claude Code