Skip to content

Perf/workspaces list page composition#93293

Draft
WojtekBoman wants to merge 3 commits into
Expensify:mainfrom
software-mansion-labs:perf/workspaces-list-page-composition-3
Draft

Perf/workspaces list page composition#93293
WojtekBoman wants to merge 3 commits into
Expensify:mainfrom
software-mansion-labs:perf/workspaces-list-page-composition-3

Conversation

@WojtekBoman

@WojtekBoman WojtekBoman commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

WorkspacesListPage stays mounted in the background (e.g. after navigating into a workspace) and used to commit on every write to any policy (including optimistic isLoading* flips such as openPolicyWorkflowsPage), any report (via a raw COLLECTION.REPORT subscription held for the delete flow), and any personal details change. Every page commit also rebuilt the menu items and closures for all rows inline, re-rendering every row. This PR decomposes the page so that each piece of logic subscribes only to the data it needs, only for as long as it needs it:

1. Delete flow → DeleteWorkspaceFlow (mounted only while a deletion is in progress)
All delete-related subscriptions that previously lived on the page permanently — the raw COLLECTION.POLICY, the raw COLLECTION.REPORT via useTransactionViolationOfWorkspace (the single biggest source of background re-renders), card feeds, cards list, last-selected feeds, reimbursement account errors, last payment methods, subscription/account/amount-owed keys — now exist only while policyIDToDelete is set. The component orchestrates the Invoicify block, the outstanding-balance guard, bill calculation for the last paid workspace, the confirmation modal and the offline error modal, and unmounts itself when the flow finishes.

2. Row three-dots menu → WorkspaceRowThreeDotsMenu (per row)
The ~140-line getThreeDotMenuItems previously built on the page for every row moved into a per-row component that builds its items from cheap, mostly primitive-valued subscriptions: SESSION, NVP_ACTIVE_POLICY_ID, FUND_LIST → boolean, ACCOUNTcanDowngrade, NVP_PRIVATE_AMOUNT_OWED, IS_LOADING_BILL_WHEN_DOWNGRADE, and an owned-paid-policies-counts selector. The hide-popover-when-bill-loading-ends effect moved here from WorkspaceTableRow.

3. Leave / transfer ownership → LeaveWorkspaceAction / TransferOwnershipAction (mounted on click)
Both flows need the full policy entry (connections for exporters, technicalContact, achAccount.reimburser, errorFields.changeOwner), so they subscribe to POLICY${id} only for the lifetime of the action and unmount when it completes. At rest the rows hold no full-policy subscriptions, so isLoading* flips no longer re-render them.

4. Error indicator → WorkspaceRowBrickRoadIndicator (per row)
The page-level brick-road computation required the raw COLLECTION.POLICY, the whole POLICY_CONNECTION_SYNC_PROGRESS collection, the raw REIMBURSEMENT_ACCOUNT and usePoliciesWithCardFeedErrors (a second raw COLLECTION.POLICY subscription). It is replaced by four narrow per-row subscriptions (useWorkspaceAccountID, DERIVED.CARD_FEED_ERRORS → boolean, REIMBURSEMENT_ACCOUNT → boolean, POLICY_CONNECTION_SYNC_PROGRESS${id} + POLICY${id} → boolean). A change to a deep policy field now re-renders at most one row's indicator instead of committing the whole page.

5. Page subscriptions → narrow selectors

  • Raw COLLECTION.POLICYcreateWorkspaceListPoliciesSelector: a flat ~11-field projection per policy (id, name, type, role, ownerAccountID, avatarURL, pendingAction, errors, isPendingDelete, isJoinRequestPending, nonMemberDetails) with the shouldShowPolicy filter inside the selector, so its deepEqual is blind to isLoading*/employeeList/connections and cheap to compare.
  • usePersonalDetails() (full context) → createDisplayDetailsByAccountIDsSelector limited to the owner account IDs shown in the list.
  • The page-level copy-settings memo over raw policies → createCopySettingsEligibleTargetsSelector returning two ID arrays, evaluated once per policy write at the page level and passed down to the row menus (avoids O(N²) per-row evaluation).
  • isUserReimburserForPolicy changed from a collection-based to a per-policy signature and moved next to its only consumer (LeaveWorkspaceAction).

Result: background writes — report changes, isLoading* flips, deep policy field mutations, unrelated personal details updates — no longer commit WorkspacesListPage at all. Genuine row-data changes (name, avatar, role, errors, pending actions) still re-render the page as expected, and deep-field errors commit only the affected row's indicator.

Fixed Issues

$
PROPOSAL:

Tests

Test 1: Three-dots menu, leave and transfer flows

  1. Sign in with an account that is an admin (but not the owner) of at least one workspace and the owner of another
  2. Go to Settings > Workspaces
  3. Open the three-dots menu on a workspace you own and verify it shows: Go to workspace, Duplicate workspace, Set as default workspace (when not default), Delete
  4. Open the three-dots menu on a workspace you administer but don't own and verify it shows: Go to workspace, Leave, Duplicate workspace, Transfer owner (when a payment card is available)
  5. Select "Set as default workspace" and verify the Default badge moves to that row
  6. Select "Leave" on a workspace you don't own and verify a confirmation modal appears with the prompt matching your role (member/admin/auditor/approver/exporter/technical contact/reimburser — the reimburser variant has no cancel button and does not allow leaving)
  7. Confirm leaving and verify the workspace disappears from the list

Test 2: Delete workspace from the row menu

  1. Go to Settings > Workspaces and open the three-dots menu on a workspace you own
  2. Select "Delete" and verify the delete confirmation modal appears (with the card-feed copy variant if the workspace has cards)
  3. If it is your last paid workspace, verify a loading spinner shows on the Delete item while the bill is calculated and the popover closes when it finishes
  4. Confirm deletion and verify the workspace is removed from the list and its reports are archived

Test 3: Per-row error indicator and no background re-renders

  1. Sign in as an admin of a workspace with a broken accounting connection or an employee list error (alternatively, add an invalid bank account so the reimbursement account has errors)
  2. Go to Settings > Workspaces and verify a red dot indicator shows next to the three-dots menu of the affected workspace row only (and only on rows where you are an admin)
  3. Open React DevTools Profiler and start recording, then navigate into a workspace and open the Workflows page (this flips the policy isLoading flag)
  4. Verify that WorkspacesListPage does not commit in the profiler trace while in the background

Offline tests

  1. Go offline (disable network)
  2. Go to Settings > Workspaces, open the three-dots menu on a workspace you own and select "Delete"
  3. Confirm deletion and verify the row shows the pending-delete (greyed out) state
  4. Go back online and verify the workspace is removed from the list

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@WojtekBoman

Copy link
Copy Markdown
Contributor Author

@codex

@WojtekBoman WojtekBoman changed the title Perf/workspaces list page composition 3 Perf/workspaces list page composition Jun 11, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant