cam6_4_182: Updates to CAM build of TUV-X lib#1577
Open
fvitt wants to merge 6 commits into
Open
Conversation
modified: bld/build-namelist modified: bld/config_files/definition.xml modified: bld/configure modified: cime_config/buildlib modified: cime_config/buildnml modified: cime_config/config_component.xml modified: cime_config/testdefs/testmods_dirs/cam/carma_mixed_sulfate/shell_commands modified: cime_config/testdefs/testmods_dirs/cam/outfrq9s_tuvx_waccm_ma_mam5/shell_commands modified: cime_config/testdefs/testmods_dirs/cam/outfrq9s_waccm_ma_mam4/shell_commands modified: src/chemistry/mozart/mo_tuvx.F90
modified: cime_config/buildlib
cacraigucar
approved these changes
Jun 11, 2026
cacraigucar
left a comment
Collaborator
There was a problem hiding this comment.
Recommend possibly looking at the #ifdef's one more time to see if all the code they encapsulate really needs to be encapsulated. I realize this is the easiest way to proceed and since it is deep in mozart code, I'm not going to push back on it. I'm guessing some of the encapsulation could be external and controlled by a passed in use_tuvx logical. Again, nothing I am going to require though
jimmielin
requested changes
Jun 11, 2026
Haipeng's suggestion Co-authored-by: Haipeng Lin <myself@jimmielin.me>
Haipeng's suggestion Co-authored-by: Haipeng Lin <myself@jimmielin.me>
Haipeng's suggestion Co-authored-by: Haipeng Lin <myself@jimmielin.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds the TUV-x library only when CAM is configured for TUV-X. A configure option (-tuvx) has been added which is required for cases that use TUV-X photolysis.
Closes #1537
Closes #1570