sugarjar: add new dependency#287359
Conversation
| end | ||
|
|
||
| depends_on "gh" | ||
| depends_on "glab" |
There was a problem hiding this comment.
If this could be optionally installed later, then maybe it is worth because of the dependency size is about ~50MB. Is this really needed?
There was a problem hiding this comment.
SJ isn't super useful without at least one of these. Technically, you might only need one or the other, but it's a suboptimal experience to only have it work with one kind of repo. And the go binary is a lot smaller than, say, ruby and the dozen libraries we depend on anyway :)
There was a problem hiding this comment.
My suggestion is remove both gh and glab if they don't need at the build time. Once user hit the command that require gh or glab, you could give them a message to install gh or glab separately. Then then could install what they required not just install both for all.
The bot bumped to 3.0.0, which is great, and works, but if `glab` is installed, `sugarjar` now has gitlab support, so we should add that to the dependencies. Signed-off-by: Phil Dibowitz <phil@ipom.com>
|
That test failure seems to be an unrelated, transient, issue: |
The bot bumped to 3.0.0, which is great, and works, but if
glabis installed,sugarjarnow has gitlab support, so we should add that to the dependencies.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>?brew test <formula>?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?