fix: resolve root path via symlink targets#1126
Open
GunniBusch wants to merge 1 commit into
Open
Conversation
|
|
7 tasks
d8d4ae8 to
23e98b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When GammaRay is invoked through a symlinked executable,
QCoreApplication::applicationDirPath()points at the symlink directory. Resolve the executable path first so relative root paths are based on the real executable location.This helps downstream package layouts that link the executable from a separate prefix while keeping the Qt plugin/root layout beside the real binary.
AI-assisted contribution by OpenAI Codex. Codex just opened the pr. The 3 lines were done by my brain.