EXT_mesh_primitive_edge_visibility#2479
Conversation
|
@kring @javagl @lexaknyazev or others - do you have any additional feedback for @pmconne on this extension? |
|
@pmconne I read through the spec again and I think this looks great! No further suggestions from me. I would like to see a complete implementation of this extension in CesiumJS or iTwinJS, though, if there isn't one already. It would be useful both as proof that it can be implemented sensibly in WebGL (2?), and for my own interest in the rendering techniques involved. |
Most of the rendering pieces are already in place in iTwin.js. I think the quickest path to a complete implementation would be for me to update the iModel -> 3D Tiles pipeline to encode the edges according to the spec and update iTwin.js decode accordingly. |
|
The spec has been updated to now list CesiumJS as a known implementation in addition to iTwin.js. These implementations have the caveat that they do not implement the full capability of this specification, namely materials. This support is forthcoming. |
|
|
|
In addition to the review comments please optimize all PNG images with |
|
@lexaknyazev Thanks! I’ve gone through and updated all the PR feedback. |
weegeekps
left a comment
There was a problem hiding this comment.
I'd like to get this merged today. @markschlosseratbentley, you've got two changes that are needed and then we should be good to go since this is a Vendor extension.
…E.md Co-authored-by: Adam Morris <adam@cesium.com>
The
EXT_mesh_primitive_edge_visibilityextension augments a triangle mesh primitive with sufficient information to enable engines to produce non-photorealistic visualizations of 3D objects with visible edges. The edge visibility is encoded in a highly compact form to avoid excessively bloating the glTF asset. Adapted for glTF from iTwin/itwinjs-core#5581. We intend to add support for the extension to the CesiumJS engine.