Make the ID optional when parsing a module#41
Open
matiix310 wants to merge 1 commit into
Open
Conversation
❌ Deploy Preview for infinity-pegasus failed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
With the current parsing, the first word of the module name is interpreted as an ID. However there are some modules without any ID and / or with multiple words. This fix changes the regex so that the ID is now parsed as intended:
Regex
Old regex
New regex
Context
In my Promo (2027) the modules can have multiple words and do not have ID for most of them. Therefore their name and ID are mixed up and sometimes they only have an ID and no name (name is considered as an ID).