cvs/rccl: surface oversubscription as WARN, per-test dmesg window, per-user hostfile#169
Open
speriaswamy-amd wants to merge 2 commits into
Open
cvs/rccl: surface oversubscription as WARN, per-test dmesg window, per-user hostfile#169speriaswamy-amd wants to merge 2 commits into
speriaswamy-amd wants to merge 2 commits into
Conversation
3 tasks
Per AMD docs the runlist/VM-context oversubscription messages are real perf-degrading conditions (HW scheduler round-robins queues, blocking the GPU for ms-scale windows), not benign info. Earlier patch dropped them from the failure regex entirely, which suppressed the signal: a perf run in a degraded HW state would now be marked PASS and its bandwidth deltas silently trusted. Add a warn_patterns_dict alongside err_patterns_dict; verify_dmesg_for_errors now scans both. Err matches still fail_test (no behavior change). Warn matches emit log.warning with a "perf numbers may not be trustworthy" note so the run is visibly flagged in std.log without failing the collective itself. Backward compatible: function signature and return shape unchanged, all other callers untouched. Ref: https://instinct.docs.amd.com/projects/amdgpu-docs/en/latest/conceptual/oversubscription.html Co-authored-by: Cursor <cursoragent@cursor.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three small fixes from debugging a 28-node
rccl_perfrun on a shared cluster:cvs/lib/verify_lib.py— surface amdgpu runlist oversubscription as a non-fatal WARN. Per AMD docs (Runlist is getting oversubscribed,Expect reduced ROCm performance), this is a real perf-degrading state — the HW scheduler round-robins queues and inactive queues can block the GPU for ms-scale windows. The collective itself completes correctly, so we don't fail the test, but we do log aWARNline so reviewers know the perf numbers from this run were measured under a degraded HW state and shouldn't be trusted blindly. Implemented via a new module-levelwarn_patterns_dictscanned alongsideerr_patterns_dictinsideverify_dmesg_for_errors. Backward-compatible — function signature and return shape unchanged, all 7+ existing callers untouched.cvs/tests/rccl/rccl_perf.py— flipverify_dmesg_for_errors(..., till_end_flag=False)so the dmesg scan is bounded by each parametrized test's ownstart_time/end_timewindow. Withtill_end_flag=Truethe scan ran fromstart_timeto the end of the dmesg buffer, so a kernel event from one test (e.g. ascatter_perfsegfault) was re-flagged as a failure for every subsequent parametrized test in the run.cvs/lib/rccl_lib.py— write the mpirun hostfile to/tmp/rccl_hosts_file_<USER>.txtinstead of the shared/tmp/rccl_hosts_file.txt. A leftover hostfile owned by another user blocks the run withOperation not permitted/Permission deniedon shared cluster nodes.Why the WARN approach (not drop-from-failures)
Earlier rev of this PR dropped the oversubscription patterns from the failure regex outright. That made the run "green" but threw away the signal — a perf run in a degraded HW state would now be marked PASS and its bandwidth deltas silently trusted. Demoting to a WARN bucket separates the two questions:
std.log.Real driver-side errors (
Queue preemption failed,Failed to evict process queues,No more SDMA queue to allocate,amdgpu: process pid) still match the FAIL regex and behave as before.Test plan
WARNlines instd.log.Test failureand segfault still fail the correct (and only the correct) test after the per-test window change.Refs: AIMVT-175