Follow-on to #7150: validate for readingtime directive#7157
Follow-on to #7150: validate for readingtime directive#7157trexfeathers wants to merge 1 commit into
readingtime directive#7157Conversation
There was a problem hiding this comment.
Templating
This PR includes changes that may be worth sharing via templating. For each file listed below, please either:
- Action the suggestion via a pull request editing/adding the relevant file in the SciTools/.github
templates/directory. 1 - Raise an issue against the SciTools/.github repo for the above action if you really don't have 10mins spare right now. Include an assignee, to avoid it being forgotten.
- Dismiss the suggestion if the changes are not suitable for templating.
You will need to dismiss this review before this PR can be merged. Recommend the reviewer does this as their final action before merging, as this text will continually update as commits come in.
Template candidates
The following changed files are not currently templated, but their parent directories suggest they may be good candidates for a new template to be created:
Footnotes
-
Include this text in the PR body to avoid any notifications about applying the template changes back to the source repo!
@scitools-templating: please no update notification on: iris↩
|
This change is Iris-specific |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7157 +/- ##
=======================================
Coverage 90.14% 90.14%
=======================================
Files 91 91
Lines 24967 24967
Branches 4684 4684
=======================================
Hits 22506 22506
Misses 1683 1683
Partials 778 778 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
@bjlittle @tkknight I wanted to make this suggestion on #7150 but you were too quick for me!
The
readingtimedirective seems like one of those useful features that is prime to be forgotten when people add new pages. What do you think of this validator idea? 1Footnotes
no problem if it's too much. Only took 30mins to write agentically. ↩