Skip to content

fix: Fix Audit/Attackathon reports (Phase 2)#7537

Open
gregtatcam wants to merge 1 commit into
developfrom
gregtatcam/mpt/audit-attackathon-fixes-2
Open

fix: Fix Audit/Attackathon reports (Phase 2)#7537
gregtatcam wants to merge 1 commit into
developfrom
gregtatcam/mpt/audit-attackathon-fixes-2

Conversation

@gregtatcam

Copy link
Copy Markdown
Collaborator

High Level Overview of Change

Fix:

  • CheckCash hard caps MPT DeliverMin at half of maxMPTokenAmount

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

Test Plan

Extended CheckMPT_test

@xrplf-ai-reviewer xrplf-ai-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues.

Review by Claude Sonnet 4.6 · Prompt: V15

@codecov

codecov Bot commented Jun 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.0%. Comparing base (df395d6) to head (16b8544).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #7537     +/-   ##
=========================================
- Coverage     82.0%   82.0%   -0.0%     
=========================================
  Files         1009    1009             
  Lines        76779   76784      +5     
  Branches      8937    8935      -2     
=========================================
+ Hits         62976   62979      +3     
- Misses       13794   13796      +2     
  Partials         9       9             
Files with missing lines Coverage Δ
src/libxrpl/tx/transactors/check/CheckCash.cpp 89.8% <100.0%> (+0.2%) ⬆️

... and 2 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gregtatcam gregtatcam force-pushed the gregtatcam/mpt/audit-attackathon-fixes-2 branch from 3e947f8 to 16b8544 Compare June 13, 2026 12:32

@xrplf-ai-reviewer xrplf-ai-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues.

Review by Claude Sonnet 4.6 · Prompt: V15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant