fix: write component bit count when writing metadata#98
Open
PintoCraig wants to merge 5 commits into
Open
Conversation
Contributor
|
Hi @PintoCraig from what I can see this looks fine for me. |
Contributor
Author
|
This will be fixed in libczi as part of this issue ZEISS/libczi#156 |
Contributor
|
@PintoCraig - so how do we proceed here now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[x] I followed the How to structure your PR.
[ ] Based on Commit Parsing: In case a new major release will be created (because the body or footer begins with 'BREAKING CHANGE:'), I created a new Jupyter notebook with a matching version.
[x] Based on Commit Parsing: In case a new minor/patch release will be created (because PR title begins with 'feat'/('fix' or 'perf')), I optionally created a new Jupyter notebook with a matching version.
[ ] In case of API changes, I updated API.md.
Summary of the change(s) and which issue(s) is/are fixed
Relevant motivation and context
Dependencies required for this change
Fixes # (issue)
When writing a czi, the ComponentBitCount is missing, causing a warning in CziCheck. Fixed by inferring the value.