Skip to content

[coordinator] add support for tags in rollup rules#3279

Open
shreyassrivatsan wants to merge 2 commits into
masterfrom
ss/rollup
Open

[coordinator] add support for tags in rollup rules#3279
shreyassrivatsan wants to merge 2 commits into
masterfrom
ss/rollup

Conversation

@shreyassrivatsan

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:
This PR adds support for custom tags in rollup rule definitions. These tags will enable different functionality in rollup rules based on provided custom tags.

Does this PR introduce a user-facing and/or backwards incompatible change?:
NONE

Does this PR require updating code package or user-facing documentation?:
NONE

@codecov

codecov Bot commented Sep 11, 2023

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 40.90909% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.5%. Comparing base (812d585) to head (1094af8).
⚠️ Report is 769 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (812d585) and HEAD (1094af8). Click for more details.

HEAD has 54 uploads less than BASE
Flag BASE (812d585) HEAD (1094af8)
aggregator 15 7
dbnode 10 7
query 10 3
collector 16 7
cluster 14 7
m3ninx 9 3
m3em 15 7
x 9 3
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3279      +/-   ##
==========================================
- Coverage    71.1%    50.5%   -20.6%     
==========================================
  Files        1098     1089       -9     
  Lines      101644   100355    -1289     
==========================================
- Hits        72291    50749   -21542     
- Misses      24245    45374   +21129     
+ Partials     5108     4232     -876     
Flag Coverage Δ
aggregator 60.2% <ø> (-16.3%) ⬇️
cluster 48.1% <ø> (-36.7%) ⬇️
collector 54.3% <ø> (-30.0%) ⬇️
dbnode 70.0% <ø> (-5.7%) ⬇️
m3em 52.2% <ø> (-22.2%) ⬇️
m3ninx 60.3% <ø> (-13.3%) ⬇️
metrics 20.0% <40.9%> (+<0.1%) ⬆️
msg 73.9% <ø> (-0.2%) ⬇️
query 13.5% <ø> (-53.8%) ⬇️
x 54.0% <ø> (-26.6%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 812d585...1094af8. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant