Implemented fix proposed by Kevalz95, Issue #564, in modbus_server.py#613
Open
MotherFraggr wants to merge 2 commits into
Open
Implemented fix proposed by Kevalz95, Issue #564, in modbus_server.py#613MotherFraggr wants to merge 2 commits into
MotherFraggr wants to merge 2 commits into
Conversation
Member
|
@MotherFraggr thank you for the contribution. Could you review the failing check? |
Author
|
@glaslos - I reformatted the file based on the failing Black check, is there a way to run these checks locally if I have future contributions? Thanks! |
glaslos
requested changes
Jun 7, 2026
| # Adds stall counter to prevent infinite loop on malformed requests | ||
| while len(request) < (length + 6): | ||
| try: | ||
| if previous_request and len(previous_request) == len(request): |
Member
There was a problem hiding this comment.
this will be always true on the second iteration.
Check request length before and after recv()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements a fix to the while-loop issue in modbus_server.py that was recommended inside of Issue #564. This has been tested within a Docker container given a public IP address and has alleviated the issue with crashing that was present before.