Issue #59 - graphics texture#265
Open
bgordley wants to merge 2 commits into
Open
Conversation
Contributor
|
Thanks for contributing! :) This change would only cover rectangular shapes and not Circles, Polygons, etc. The goal of this issue is to replicate Slick2D's similar function found here. In regards to your questions:
|
Author
|
Awesome! I'll dig into the Slick2D functionality and come up with a solution that passes UAT behavior. Thanks for the feedback! |
Author
|
Spent some time reviewing the Slick2D implementation of textures applied to shapes. Here is my understanding of the desired behavior.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed that issue #59 was tagged with help wanted so I jumped in to help. Here is a brief description of what I changed and some additional questions that I have.
What Changed
Questions
Thanks for your time, hopefully this is helpful. 😄