Set Mach absolute time platform-specific reference timestamp on macOS#810
Merged
Conversation
mstange
approved these changes
May 7, 2026
mstange
left a comment
Owner
There was a problem hiding this comment.
Oh I'm surprised we weren't doing this already. Thanks!
For some reason this PR doesn't have an "Update branch" button so I can't merge it until you push a rebased / merged version. Maybe you didn't have the "allow edits by maintainer" checkbox checked?
289fb77 to
2ecb34c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into an issue on MacOS, when trying to reconstruct the monotonic timer value of a specific sample (since the reference timestamp was discarded before). My use case is extracting specific samples based on a monotonic time range.
By saving it inside the profile.json, we can reconstruct it again by adding the reference timestamp.