[Outdated] Add CRA metrics. Keeping until CRA fully resolved.#940
[Outdated] Add CRA metrics. Keeping until CRA fully resolved.#940tennlee wants to merge 2 commits into
Conversation
* Add CRA metrics * add brute force search, valid fraction mask * add max distance arg * add cra_2d with reduce_dims arg * specify obs or fcst in largest_blob_label * replace calc_shifted_forecast with translate_forecast_region * adjust cra to reduce_dims
Signed-off-by: Stephanie Chong <168800785+Steph-Chong@users.noreply.github.com>
|
@esteban-abellan I have updated included.md. You can see how it is currently rendering here: https://scores.readthedocs.io/en/228-documentation-testing-branch/included.html#spatial Could you please confirm:
Please feel free to either make any changes yourself, or let me know what you would like changed and I can sort it out - whatever suits :-). (Note: please disregard any broken tutorial links. I don't know why that is currently happening on included.html as rendered on branch 228. I think that's something @tennlee will need to investigate). |
|
Thanks @Steph-Chong ! The two references should be listed for all three CRA functions - sorry for the confusion. I've added this to the docstring in my next commit and fixed a few formatting issues in the
|
|
I don't think I have permission to commit directly to the upstream branch, but you should be able to see my commit on my fork: d6c22b8 |
What I did was open a new pull request (#941) with my changes, but I changed the base branch from the default |
|
Ok, I'm not entirely sure if I did this the right way, but I committed the docstring fix to my |
|
Hi Esteban. What you did in git to cra_staging branch was great, that's the right approach. However, the docstring rendering doesn't like the formatting you used in your docstring. The docs rendering is super brittle to minor formatting things, so don't feel bad. I'll pull down your change later, tidy up the formatting, and push it up into the main staging branch. Once that's done you'll need to reset your branch accordingly. |
We have merged Esteban's work into a staging directory on the main repo so that some additional documentation work and refactoring can occur prior to the merge to develop.