HTTP Auth "Bleed Through" Fix#15
Open
cognusion wants to merge 1 commit into
Open
Conversation
|
Great stuff, I also made a similar hack on my deployment, it still works nicely - users don't have to bother with entering passwords, and all their actions can be audited as usernames are stored in logs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically, if we disable NConf auth, but allow Apache (or whatever) to do it, which will (generally) set the REMOTE_USER variable, trust that. Has been in use since April in a pretty big shop, in combination with an LDAP-based SSO regime.