Skip to content

Atomic mpp#827

Open
chenyukang wants to merge 58 commits into
nervosnetwork:developfrom
chenyukang:atomic-mpp
Open

Atomic mpp#827
chenyukang wants to merge 58 commits into
nervosnetwork:developfrom
chenyukang:atomic-mpp

Conversation

@chenyukang

@chenyukang chenyukang commented Aug 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Implementation for #911

@chenyukang chenyukang marked this pull request as draft August 11, 2025 16:41
@chenyukang chenyukang moved this to 🏗 In progress in Kanban Aug 15, 2025
@codecov-commenter

codecov-commenter commented Aug 19, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 731 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (e367c05) to head (fa6dc16).

Files with missing lines Patch % Lines
crates/fiber-lib/src/fiber/network.rs 0.00% 186 Missing ⚠️
crates/fiber-lib/src/fiber/gen/invoice.rs 0.00% 156 Missing ⚠️
crates/fiber-lib/src/store/store_impl/mod.rs 0.00% 86 Missing ⚠️
crates/fiber-lib/src/fiber/builtin_records.rs 0.00% 66 Missing ⚠️
crates/fiber-lib/src/fiber/amp.rs 0.00% 63 Missing ⚠️
crates/fiber-lib/src/invoice/invoice_impl.rs 0.00% 60 Missing ⚠️
crates/fiber-lib/src/fiber/channel.rs 0.00% 55 Missing ⚠️
crates/fiber-lib/src/rpc/invoice.rs 0.00% 38 Missing ⚠️
crates/fiber-lib/src/utils/payment.rs 0.00% 9 Missing ⚠️
crates/fiber-lib/src/fiber/types.rs 0.00% 6 Missing ⚠️
... and 2 more
Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #827    +/-   ##
========================================
  Coverage     0.00%   0.00%            
========================================
  Files           61      63     +2     
  Lines        38143   38718   +575     
========================================
- Misses       38143   38718   +575
Flag Coverage Δ
unittests 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jjyr
jjyr reviewed Aug 28, 2025
View reviewed changes
Comment thread crates/fiber-lib/src/fiber/types.rs Outdated
Comment thread crates/fiber-lib/src/invoice/invoice_impl.rs Outdated
jjyr
jjyr reviewed Sep 2, 2025
View reviewed changes
Comment thread crates/fiber-lib/src/store/store_impl/mod.rs
Comment thread crates/fiber-lib/src/fiber/channel.rs Outdated
Comment thread crates/fiber-lib/src/fiber/channel.rs
jjyr
jjyr reviewed Sep 18, 2025
View reviewed changes
Comment thread crates/fiber-lib/src/fiber/network.rs
@chainTe

chainTe commented Jun 9, 2026

Copy link
Copy Markdown

Security Review

Result: 1 confirmed finding
Reviewed range: a3428c8fdcc58e04a484d355f6d9bee3c697d9c3..2ae33b47ed6d9db2a1824086164a7fb642fd6605

Validation:

  • Existing broad tests were not run locally; CI is expected to cover them.
  • Focused static review found a persistence migration concern: PR 827 changes serialized payment/channel state (SendPaymentData, Attempt, and TlcInfo) and adds store prefixes without a matching migration/defaulting path, while existing store reads use strict bincode deserialization. Existing nodes with pre-PR payment/session/channel rows may fail validation, query, retry/resume, or channel restore after upgrade.

Notes:

  • Suggested fix: add a migration or backward-compatible serde/default handling for old rows, including tests that open pre-PR serialized PaymentSession, Attempt, and channel/TLC state with the PR build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jjyr jjyr jjyr left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

Kanban
Status: 🏗 In progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chenyukang @codecov-commenter @chainTe @jjyr