Skip to content

Collect intervallist channel output and propagate to genotyping step#1872

Open
percyfal wants to merge 2 commits into
nf-core:devfrom
percyfal:fix-interval-sites
Open

Collect intervallist channel output and propagate to genotyping step#1872
percyfal wants to merge 2 commits into
nf-core:devfrom
percyfal:fix-interval-sites

Conversation

@percyfal

@percyfal percyfal commented Apr 24, 2025

Copy link
Copy Markdown

Addresses #1870

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions

github-actions Bot commented Apr 24, 2025

Copy link
Copy Markdown

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.0.2.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

tuple val(meta), path("$prefix") , optional:true, emit: genomicsdb
tuple val(meta), path("$updated_db") , optional:true, emit: updatedb
tuple val(meta), path("*.interval_list"), optional:true, emit: intervallist
tuple val(meta), path("$interval_list"), optional:true, emit: intervallist

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heads up: these changes should be made in nf-core/modules and then imported here so others benefit from the work too :)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have opened an issue (nf-core/modules#8393) and PR to nf-core modules (nf-core/modules#8394).

@FriederikeHanssen

Copy link
Copy Markdown
Contributor

hey! Do you need to update the module, aka run nf-core modules update for the genotypegvcf module?

@percyfal

Copy link
Copy Markdown
Author

Not sure I follow. As in for this PR?

@famosab

famosab commented Aug 13, 2025

Copy link
Copy Markdown
Contributor

Yes :) but that can only be done after the PR is merged in the modules repo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants