Skip to content

Topic version warnings#4046

Open
muffato wants to merge 1 commit intodevfrom
topic_version_warnings
Open

Topic version warnings#4046
muffato wants to merge 1 commit intodevfrom
topic_version_warnings

Conversation

@muffato
Copy link
Member

@muffato muffato commented Feb 16, 2026

These warnings can be ignored if the subworkflow is using topic channel.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@muffato muffato self-assigned this Feb 16, 2026
Copilot AI review requested due to automatic review settings February 16, 2026 22:46
@codecov
Copy link

codecov bot commented Feb 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.40%. Comparing base (d412651) to head (d5785ae).

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves warning messages in the nf-core subworkflow linting system by adding helpful context about when version-related warnings can be safely ignored. The changes clarify that warnings about missing software versions can be disregarded when subworkflows use topic channels, which handle version information differently.

Changes:

  • Updated warning messages to indicate that version-related warnings can be ignored when using topic channels

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
nf_core/subworkflows/lint/subworkflow_tests.py Enhanced warning message for missing versions in snapshot files to clarify when the warning can be ignored
nf_core/subworkflows/lint/main_nf.py Enhanced warning message for subworkflows that don't emit software versions to clarify when the warning can be ignored

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@muffato muffato force-pushed the topic_version_warnings branch from 22bd2fa to d5785ae Compare February 16, 2026 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant