Add support for new webpack asset manifest format#42
Open
aeaston wants to merge 1 commit intonikushi:masterfrom
Open
Add support for new webpack asset manifest format#42aeaston wants to merge 1 commit intonikushi:masterfrom
aeaston wants to merge 1 commit intonikushi:masterfrom
Conversation
webpack-asset-manifest introduced a new format in v4. In order to support prefetch and preload, assets are not nested under an assets key in the entrypoints object. This commit updates the manifest parsing logic to support this new version in addition to the previous. More info on the manifest changes can be found at https://www.npmjs.com/package/webpack-assets-manifest#new-in-version-4
drewdrewthis
approved these changes
Jun 3, 2021
drewdrewthis
left a comment
There was a problem hiding this comment.
LGTM -- I hope we can get this merged.
| context 'with name with ext' do | ||
| let(:path) { File.expand_path('../support/files/manifest.json', __dir__) } | ||
| let(:name) { 'application.js' } | ||
| let(:type) { nil } |
There was a problem hiding this comment.
Since this seems like a default, you can probably leave it up in the describe scope and override it as needed (like on line 37)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39
webpack-asset-manifest introduced a new format in v4. In order to support prefetch and preload, assets are now nested under an assets key in the entrypoints object. This commit updates the manifest parsing logic to support this new version in addition to the previous.
More info on the manifest changes can be found here
NOTE: after making these changes, I noticed Szeliga has a PR that also solves this problem. I think the approach here is a lot simpler than adding a configuration option, although I suppose that might be more extensible in the future. I don't expect manifest formats to change often though, so I still prefer this solution personally. But merging either would solve my problem and make me happy =)