we might be able to use file_name here instead, so we don't have to do strip_prefix later. the same applies to open_subdirs

file_name only returns the final component, not the N - 1 final components

we should still allow packages to opt out of sourceRoot even when there are candidates

hmmm why?

workspaces?

e.g. there can be a rust binary at root that also have a library and a python binding of the library in a subdirectory, but we might want the rust binary instead of the python binding

We only have to make it so that sourceRoot candidate include the root src dir, right?

actually why

    let src_dir = choice
        .parse()
        .ok()
        .and_then(|i: usize| sourceroot_candidates.get(i))
        .unwrap_or_else(|| &sourceroot_candidates[0]);
    let source_root = if src_dir != &root_src_dir {
        Some(src_dir)
    } else {
        None
    };

is not enough?

if your choice is the rootdir, then you don't get a sourceRoot

that would also work, but we would need extra logic to be able to omit the sourceRoot = part

actually why <...> is not enough?

I haven't checked since the current HEAD is not building for me, but I think source_candidates never contains root_src_dir

yes, fixing