add warning messages when wayland fails to load due to shared libraries#503
Open
Adjective-Object wants to merge 2 commits intonot-fl3:masterfrom
Open
add warning messages when wayland fails to load due to shared libraries#503Adjective-Object wants to merge 2 commits intonot-fl3:masterfrom
Adjective-Object wants to merge 2 commits intonot-fl3:masterfrom
Conversation
Contributor
Author
|
For reference I wasn't able to fully test this -- it looks like there's some unrelated failing tests in |
not-fl3
reviewed
Dec 12, 2024
src/native/linux_wayland.rs
Outdated
| let client = LibWaylandClient::try_load()?; | ||
| let egl = LibWaylandEgl::try_load()?; | ||
| let xkb = LibXkbCommon::try_load()?; | ||
| let client = eprint_iferr("libwayland-client", LibWaylandClient::try_load())?; |
Owner
There was a problem hiding this comment.
Maybe try_load could return a better message instead of handling this here?
Contributor
Author
There was a problem hiding this comment.
for sure, I can handle the errors in the try_load() fns
Contributor
Author
|
Verified that the latest round of changes i pushed still works by running within a docker container with missing dependencies: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to debug why macroquad was failing to run in a container, I ran into a variation of this issue, which turned out to just be that I was missing
libwayland-eglin the container.This would have been more straightforward to debug if miniquad printed the reason it failed to initialize when it fails, which it does in a few other scenarios.
This change adds eprintln! warnings when a required library is missing