native/linux: Use macro to reduce boilerplate#533
Merged
not-fl3 merged 2 commits intonot-fl3:masterfrom Feb 28, 2025
Merged
Conversation
Owner
|
Great work! 👍 I am little bit on the fence about |
Contributor
Author
|
Cool! Yeah worst case we could always change it in the future since it's not exposed to the user. The Wayland backend is pretty much on a par with X11 now :) I'll open a PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids writing the same function name 5 times in 3 different places.
I didn't convert the egl file yet.Did the egl file as well. The gl one seems to have its own macro.The macro itself is inspired by the dlib crate, but I made it less verbose with the
...syntax. I'm also open to other suggestions.Once this got merged I'll start submitting the PRs for the Wayland backend :)