android: set or replace display to allow restarting UI when foreground service is enabled#564
Merged
Merged
Conversation
…d service is enabled
Owner
|
Thanks for PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Android, when you have an app in the background for a few secs it will be closed. Also most users will just close the app when they intend to minimize.
This is annoying if you're downloading stuff in the background. Every time you restart the app, you have to redo initialization such as connecting to services and so on. The way to handle this in Android is to create a long running
ForegroundService.However then globals remain persistent, and miniquad will crash due to the display having been already initialized. So this commit fixes that by replacing the display if already initialized. It doesn't change existing usage of Android apps.